Allow template for sendgrid (if exists)

[SteveDMurphy]

Closes #1866

Code Changes

• Include the option of having a template email with SendGrid
• Handle paging of template IDs Use max for now and circle back (as needed)

Steps to Confirm

• Create a template to use for testing
• Submit a request to use the template

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md

Description Of Changes

This is following the same path that was set out for Mailgun, only minor differences exist in how the template is discovered and applied. The pagination for the SDK is not functioning, so to hit the release and not over-engineer I just ended up setting the max. Will add a comment in the files changed as well to highlight and see if we want to add a follow on issue now or wait until it becomes a problem

[cypress]

Passing run #611 ↗︎

0

3

0

0

0

Details:

Merge 8b34c53 into 2afc8b6...
Project: fides	Commit: 94f35dc4f7 ℹ️
Status: Passed	Duration: 00:35 💡
Started: Mar 3, 2023 10:28 PM	Ended: Mar 3, 2023 10:28 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 81.81% and no project coverage change

Comparison is base (2afc8b6) 86.59% compared to head (8b34c53) 86.60%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2728   +/-   ##
=======================================
  Coverage   86.59%   86.60%           
=======================================
  Files         290      290           
  Lines       16224    16242   +18     
  Branches     2062     2065    +3     
=======================================
+ Hits        14049    14066   +17     
- Misses       1792     1793    +1     
  Partials      383      383           

Impacted Files	Coverage Δ
.../ops/service/messaging/message_dispatch_service.py	62.38% <81.81%> (+2.77%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SteveDMurphy]

@adamsachs after reading your message on messaging ( 😏 ) thought you might be ok to review this. Adding a bit early as I grapple with codecov 🤼 and wrap up any admin stuff

[adamsachs]

i like the way this looks! simple and clean implementation. the only thing i found in the code is that hardcoded limit that you've called out, due to the limitation in the SDK/client - i think your decision to hardcode is totally fine for now, but i had a couple of notes on it. nothing critical but let me know what you think. and let me know if you're running into any issues grappling with codecov, happy to lend a hand if i can.

also, is there a fidesdocs ticket to update our docs explaining how to use this functionality? let's make sure we at least ticket that before merging this in - ideally we can also just quickly make those doc updates since we've got a lot of the necessary content about templating already there for mailgun it seems, and it feels like the type of thing that if we don't update now, it may just sit stale unnecessarily.

last thing - were you able to run a manual end-to-end test actually using a template in sendgrid? happy to help with that if needed - but seems like you've likely done that considering the pagination bug you've found? (i just want to be sure!)

[SteveDMurphy]

Docs issue created -> fidesdocs#68