Consent Privacy Request Status when Identity Verification Required

[pattisdr]

Closes #2735

Code Changes

• Update the logic as to which initial status a Privacy Request is given. If the request is already authenticated, even if subject_identity_verification_required=True, this should be a PENDING request, not "identity unverified". This was putting the consent request in a non-executable state. It's identity was already verified, but the privacy request is sitting there in the wrong state and can't be manually approved.

Steps to Confirm

• Set your src/fides/data/test_env/fides.test_env.toml file to have subject_identity_verification_required = true
• Update one consent option in the test env config.json to be executable. Rebuild the privacy center
• Run nox -s fides_env(dev)
• Setup mailgun locally
• Go to the privacy center. Do a hard refresh
• Click on Manage your consent and enter an email you control
• Go to your email and retrieve the verification code
• Return to the privacy center and enter the code into the Enter verification code modal and click submit
• Update your consent preferences and click save
• Login to the admin app. You should see the associated privacy request with a status of "New" instead of "Identity Unverified"

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md

Description Of Changes

When updating consent preferences, and subject_identity_verification_required is True, Privacy Request should be put in a status of "pending" not "identity_unverified" as identity was verified before the consent preferences were saved.

[cypress]

Passing run #575 ↗︎

0

3

0

0

0

Details:

Merge 1fbddb8 into 0e7d3f7...
Project: fides	Commit: 933884efa5 ℹ️
Status: Passed	Duration: 00:42 💡
Started: Mar 2, 2023 9:05 PM	Ended: Mar 2, 2023 9:06 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e7d3f7) 86.58% compared to head (1fbddb8) 86.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2736   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files         290      290           
  Lines       16210    16210           
  Branches     2059     2059           
=======================================
  Hits        14035    14035           
  Misses       1792     1792           
  Partials      383      383           

Impacted Files	Coverage Δ
...rc/fides/api/ops/api/v1/endpoints/drp_endpoints.py	92.00% <ø> (ø)
.../ops/api/v1/endpoints/privacy_request_endpoints.py	88.78% <ø> (ø)
.../service/privacy_request/request_runner_service.py	77.15% <ø> (ø)
...api/ops/service/privacy_request/request_service.py	91.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[seanpreston]

Thankyou @pattisdr