-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Scopes Easier to Use in the UI #2741
Conversation
- Dynamically create a ScopeRegistryEnum from the list of scopes - Make this the "type" when getting user permission scopes - Delete custom validation for scopes now that we can use the enum - If scope registry changes and user has a scope that no longer exists, filter that out instead of failing on access.
Passing run #604 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
Coverage 86.58% 86.59%
=======================================
Files 290 290
Lines 16216 16224 +8
Branches 2060 2062 +2
=======================================
+ Hits 14041 14049 +8
Misses 1792 1792
Partials 383 383
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
# Conflicts: # CHANGELOG.md # src/fides/api/ops/api/v1/scope_registry.py # tests/ops/api/v1/endpoints/test_user_permission_endpoints.py
…Enum casing to match.
Closes #2716
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Return a scopes enum so the UI can use this, as well as return "total scopes" - scopes that the user has via their roles or that they were assigned directly.