Removes Hiding By Scope for Scopes not Issuable by the UI

[pattisdr]

Closes #2769
Reverts some changes introduced in #2682

Code Changes

• Removes hiding by scope for navbar and tiles for scopes not issuable via the UI:

PRIVACY_REQUEST_READ,
PRIVACY_REQUEST_REVIEW,
PRIVACY_REQUEST_RESUME,
CONNECTION_READ,
CONNECTION_CREATE_OR_UPDATE,
CONNECTION_INSTANTIATE,
CONNECTION_TYPE_READ,
CONNECTION_DELETE,
CONSENT_READ,
DATASET_CREATE_OR_UPDATE,
DATASET_DELETE,
POLICY_READ,
POLICY_CREATE_OR_UPDATE,
USER_READ,
USER_CREATE,
USER_UPDATE,
USER_DELETE,
USER_PASSWORD_RESET,
USER_PERMISSION_CREATE,
USER_PERMISSION_UPDATE,
USER_PERMISSION_READ,
PRIVACY_REQUEST_UPLOAD_DATA,
PRIVACY_REQUEST_VIEW_DATA,
WEBHOOK_CREATE_OR_UPDATE,
WEBHOOK_READ,
WEBHOOK_DELETE,

• Fixes corresponding unit tests

Steps to Confirm

• list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

[pattisdr]

tile-config.test.ts and nav-config.test.ts unaddressed

[NevilleS]

LGTM so far. Let's get the tests disabled/skipped/passing enough for this to work and we can take our time to migrate to this system in 2.9.0

[pattisdr]

@NevilleS do you want me to do the tests as well?

[NevilleS]

I'm on it!

[cypress]

Passing run #697 ↗︎

0	3	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge f43ce6f into 05e418d...
Project: fides	Commit: 69039597b5 ℹ️
Status: Passed	Duration: 00:38 💡
Started: Mar 8, 2023 2:48 PM	Ended: Mar 8, 2023 2:49 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (05e418d) 86.55% compared to head (f43ce6f) 86.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2771   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         291      291           
  Lines       16488    16488           
  Branches     2117     2117           
=======================================
  Hits        14272    14272           
  Misses       1817     1817           
  Partials      399      399           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pattisdr]

Testing changes locally...

[NevilleS]

There was one failing Cypress test on that past run:

1) Taxonomy management page
       Can create data
         Can open a create form for each taxonomy entity:

I've re-run that one or twice locally and I think it's a flaky test - looks like a potential timing issue with how the create form opens/closes. I'm quite sure it's unrelated so don't want to hold this up further