-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow login to automatically pull from env vars #2884
Conversation
Passing run #978 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
===========================================
+ Coverage 67.30% 86.63% +19.33%
===========================================
Files 299 299
Lines 16814 16831 +17
Branches 2148 2148
===========================================
+ Hits 11316 14581 +3265
+ Misses 5093 1841 -3252
- Partials 405 409 +4
... and 133 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…omatically if available
… show assigned roles when creating user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this improvement! Everything worked great 🚀
Closes #2786
Code Changes
user.username
anduser.password
fields to the configfides user login
to pull from the config automatically if the options aren't specified, finally falling back on prompting if not provided as an option and not in the configfides user create
to use username and password arguments instead of options, display assigned roles upon successful creationusername
andpassword
to the development config fileSteps to Confirm
user.username
anduser.password
fields are set in thefides.toml
:fides user login
and confirm "it just works"fides user login -u notarealuser
and confirm it breaksuser.username
anduser.password
fields from thefides.toml
fides user login
and confirm it prompts for themfides user create newuser Testpassword1!
is successful and shows the assigned roles (alwaysowner
currently)Pre-Merge Checklist
CHANGELOG.md
Relevant Follow-Up Issues CreatedFor API changes, the Postman collection has been updatedDescription Of Changes
This PR is designed to make logging in via the CLI more user-friendly. It allows users to set a
username
andpassword
via the config file (and therefore viaenv vars
if so inclined) that will get automatically used during the login process.It should be noted that username/password are considered discrete values here, so one may configure their
username
via the config file and it will still prompt for thepassword
Login Logic Update
The new priority list is as follows:
FIDES__USER__USERNAME
)Example Config Section