Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Admin UI header & navigation #2897

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Polish Admin UI header & navigation #2897

merged 4 commits into from
Mar 22, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Mar 22, 2023

Closes #2885

Code Changes

  • Import updated top nav & side nav components from fidesui (see https://github.com/ethyca/fidesui/pull/40)
  • Update header:
    • Smaller height, vertically aligned, tighter padding
    • Statically import Fides logo (bit faster load/cache!)
    • Add help button
  • Update top nav height, vertically aligned, tighter padding

Steps to Confirm

  • Run `nox -s "fides_env(test)"
  • Compare before/after screens to master designs
Page Before After
Home image image
Privacy Requests image image

Pre-Merge Checklist

Description Of Changes

Polish pass on the header & navigation ✨

@cypress
Copy link

cypress bot commented Mar 22, 2023

Passing run #920 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c567894 into c47699c...
Project: fides Commit: 4722683ced ℹ️
Status: Passed Duration: 00:51 💡
Started: Mar 22, 2023 4:02 PM Ended: Mar 22, 2023 4:03 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c47699c) 86.61% compared to head (c567894) 86.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2897   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files         298      298           
  Lines       16783    16783           
  Branches     2147     2147           
=======================================
  Hits        14537    14537           
  Misses       1835     1835           
  Partials      411      411           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NevilleS
Copy link
Contributor Author

I got a design review for this from the design team and they gave the 👍 as-is, so this is ready to ship!

@NevilleS NevilleS merged commit 0a12888 into main Mar 22, 2023
@NevilleS NevilleS deleted the ns-polish-nav branch March 22, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish header, top navigation, and side navigation UI
2 participants