Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assigned systems to user management table #2922

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes #2861

Code Changes

  • Adds column to show number of assigned systems in user management table

Screenshot 2023-03-27 at 5 17 28 PM

Steps to Confirm

  • Add new users with varying amounts of systems. Confirm the number of systems assigned is reflected in user management table.

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented Mar 27, 2023

Passing run #1066 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0072569 into 22349a8...
Project: fides Commit: 1615568206 ℹ️
Status: Passed Duration: 00:50 💡
Started: Mar 29, 2023 12:52 PM Ended: Mar 29, 2023 12:53 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add a test case for this in cypress, too :)

@eastandwestwind
Copy link
Contributor Author

Back over to you @allisonking ! I've added a cypress test and addressed your comments

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 💯

@eastandwestwind eastandwestwind merged commit 1ca510a into main Mar 29, 2023
@eastandwestwind eastandwestwind deleted the 2861-add-assigned-systems-to-user-table branch March 29, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we add a task to show assigned systems in the user table?
2 participants