Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy centre support for more text #2943

Merged
merged 33 commits into from
Apr 11, 2023
Merged

Conversation

seanpreston
Copy link
Contributor

@seanpreston seanpreston commented Mar 29, 2023

Closes #2940

Code Changes

  • Convert description to a list that will render multiple paragraphs
  • Add addendum to display after the privacy options
  • Separate config.consent into two distinct subsections: config.consent.page and config.consent.button

Steps to Confirm

  • npm run dev and confirm the privacy centre looks like this:

Screenshot 2023-03-29 at 13 38 06

Pre-Merge Checklist

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable addition! But it'll break ;)

clients/privacy-center/pages/index.tsx Outdated Show resolved Hide resolved
clients/privacy-center/types/config.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Mar 29, 2023

Passing run #1263 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 91b24a0 into 8cd6474...
Project: fides Commit: c2bb8d1c63 ℹ️
Status: Passed Duration: 00:48 💡
Started: Apr 10, 2023 10:07 PM Ended: Apr 10, 2023 10:08 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS
Copy link
Contributor

OK this looks good now thanks :)

Can I ask for a bonus feature? Let's make the same type of formatting available on the Consent page (title, description, description_subtext, etc.)? Right now those aren't configurable 😢

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.19 🎉

Comparison is base (428ed42) 78.73% compared to head (91b24a0) 86.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   78.73%   86.92%   +8.19%     
==========================================
  Files         303      303              
  Lines       17177    17322     +145     
  Branches     2195     2230      +35     
==========================================
+ Hits        13524    15057    +1533     
+ Misses       3276     1849    -1427     
- Partials      377      416      +39     

see 70 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more asks, but once addressed don't wait for me!

clients/privacy-center/config/config.json Outdated Show resolved Hide resolved
clients/privacy-center/pages/consent.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement! just some small things that are really probably nits, do what you want with 'em :)

clients/privacy-center/constants/index.ts Outdated Show resolved Hide resolved
clients/privacy-center/scripts/validate-config.js Outdated Show resolved Hide resolved
clients/privacy-center/pages/consent.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More advanced Privacy Centre styling
3 participants