-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy centre support for more text #2943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasonable addition! But it'll break ;)
Passing run #1263 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
OK this looks good now thanks :) Can I ask for a bonus feature? Let's make the same type of formatting available on the Consent page ( |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2943 +/- ##
==========================================
+ Coverage 78.73% 86.92% +8.19%
==========================================
Files 303 303
Lines 17177 17322 +145
Branches 2195 2230 +35
==========================================
+ Hits 13524 15057 +1533
+ Misses 3276 1849 -1427
- Partials 377 416 +39 see 70 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more asks, but once addressed don't wait for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement! just some small things that are really probably nits, do what you want with 'em :)
Closes #2940
Code Changes
description
to a list that will render multiple paragraphsaddendum
to display after the privacy optionsconfig.consent
into two distinct subsections:config.consent.page
andconfig.consent.button
Steps to Confirm
npm run dev
and confirm the privacy centre looks like this:Pre-Merge Checklist
CHANGELOG.md