Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unknown as a state from fidesplus #2957

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Mar 31, 2023

Closes #2923

Code Changes

  • Only return a badge for valid statuses
  • Remove cypress tests that require a badge for unknown statuses

Steps to Confirm

  • on fidesplus, run nox -s "dev(fidesplus)"
  • generate a dataset (i.e. postgresql+psycopg2://postgres:fides@fidesplus-db:5432/fides)
  • validate the status is shown at localhost:8080
  • Spin up the admin-ui from fides (cd clients/admin-ui && npm run dev)
  • Validate the badge no longer exists on localhost:3000

Pre-Merge Checklist

Description Of Changes

This is a near term fix as discussed in planning to just remove the badge for generated only dataset in fidesplus (this should match visibility in open source)

Before:
image

After:
image

@cypress
Copy link

cypress bot commented Mar 31, 2023

Passing run #1205 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge e95b3b6 into e5b39e2...
Project: fides Commit: 5cb375f7c6 ℹ️
Status: Passed Duration: 00:39 💡
Started: Apr 6, 2023 11:05 PM Ended: Apr 6, 2023 11:05 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-2923-unknown-state branch from 337c541 to 2eaa83e Compare March 31, 2023 21:23
@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-2923-unknown-state branch from 2eaa83e to 026d364 Compare April 2, 2023 19:42
@SteveDMurphy SteveDMurphy self-assigned this Apr 2, 2023
@SteveDMurphy SteveDMurphy marked this pull request as ready for review April 3, 2023 10:31
SteveDMurphy and others added 3 commits April 6, 2023 00:53
Moved the existence check to where a badge will now first exist, and ensured that a badge does not exist at initial state.

Co-authored-by: Allison King <[email protected]>
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot, thanks for making those changes! 🙌

@SteveDMurphy SteveDMurphy merged commit b62d238 into main Apr 7, 2023
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-2923-unknown-state branch April 7, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genereated Datasets Always Show Unknown State
2 participants