-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unknown
as a state from fidesplus
#2957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1205 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
SteveDMurphy
force-pushed
the
SteveDMurphy-2923-unknown-state
branch
from
March 31, 2023 21:23
337c541
to
2eaa83e
Compare
SteveDMurphy
force-pushed
the
SteveDMurphy-2923-unknown-state
branch
from
April 2, 2023 19:42
2eaa83e
to
026d364
Compare
allisonking
reviewed
Apr 4, 2023
Co-authored-by: Allison King <[email protected]>
Moved the existence check to where a badge will now first exist, and ensured that a badge does not exist at initial state. Co-authored-by: Allison King <[email protected]>
allisonking
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woot, thanks for making those changes! 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2923
Code Changes
Steps to Confirm
nox -s "dev(fidesplus)"
postgresql+psycopg2://postgres:fides@fidesplus-db:5432/fides
)fides
(cd clients/admin-ui && npm run dev
)Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is a near term fix as discussed in planning to just remove the badge for generated only dataset in
fidesplus
(this should match visibility in open source)Before:
After: