-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamoDB Connector #2998
DynamoDB Connector #2998
Conversation
Passing run #1886 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
- Coverage 87.39% 86.94% -0.45%
==========================================
Files 305 307 +2
Lines 18265 18460 +195
Branches 2384 2407 +23
==========================================
+ Hits 15962 16050 +88
- Misses 1866 1971 +105
- Partials 437 439 +2
☔ View full report in Codecov by Sentry. |
I think this is still in a very rough state after having to rewrite everything this morning to walk back the decision to use pynamodb. Using boto3 natively seemed to make more sense instead of introducing another dependency that didn't do much for us in the end anyways.
…-dynamodb-connector
I'm still resolving a couple of spooky issues that I think were related to migration conflicts but mostly just planning to add some DynamoDB request specific unit tests and would love any early feedback @galvana ! |
Co-authored-by: Sean Preston <[email protected]>
Co-authored-by: Adrian Galvan <[email protected]>
src/fides/api/ops/schemas/connection_configuration/connection_secrets_dynamodb.py
Show resolved
Hide resolved
tests/ops/service/privacy_request/test_request_runner_service.py
Outdated
Show resolved
Hide resolved
c1cc47e
to
5eb99c6
Compare
@seanpreston expected checks are good and opened up #3278 for the two that are currently failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those extra changes @SteveDMurphy
Closes #2938
Code Changes
DynamoDB
DynamoDB
datasetStore the primary key and secondary sort (optional) as dataset metainferred fromget_item
request_runner_service
(access & erasure)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is the connector for DynamoDB, the consent component will be worked separately in both documentation and fidesplus.
It appears that some of the other unsafe checks that are not currently passing are being ignored for now, although I have validated the ones added here for DynamoDB appear to be in the clear :)
There have been more than a few migration conflicts so there may be some further need to keep up with more of those changes until this merges