-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge RTK APIs #3059
Merge RTK APIs #3059
Conversation
Passing run #1727 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
+ Coverage 87.37% 87.39% +0.02%
==========================================
Files 313 313
Lines 18241 18242 +1
Branches 2366 2365 -1
==========================================
+ Hits 15938 15943 +5
+ Misses 1871 1867 -4
Partials 432 432
☔ View full report in Codecov by Sentry. |
00d7062
to
0a4bb46
Compare
0a4bb46
to
7675d6f
Compare
@allisonking This is awesome! It's great to have everything be unified together. I'm running into some issues with logging in. I'm using Did you experience this at all while developing? |
Ah yeah auth was one of the endpoints that needed the trailing slash fix, which is only in this branch. So when you do a See if things work for you using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allisonking The changes not being propagated to fidesplus was the issue. Everything is working great!
7675d6f
to
267188b
Compare
267188b
to
79b0fb6
Compare
Closes #1386
Code Changes
createApi
s into one!/api/v1
. we could write a wrapper around our baseApi if we really wanted them all to use the same one, but the healthApi is a bit of an outlier for not being under/api/v1
imo, so I left it as-is for nowAPIRouter
that handles trailing slasheslocalhost:8080
. this is not ideal, since then you can run into cors problems when developing locally (I think our backend might allow cors to work around this though, I haven't looked into this recently). Once I updated those endpoints to use nextjs rewrites, the trailing slash problem cropped up since next always adds a trailing slashstore.ts
to be more consistent and make more sense (imo 😄 )Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats