Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow side nav bar to take children elements #3099

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 18, 2023

Closes https://github.com/ethyca/fidesplus/issues/737

Code Changes

  • Allow NavConfigRoute to itself also take NavConfigRoute as one of its props. This allows infinite nesting of side navigation menus (I doubt we'll go beyond 2 or even 3, but you never know!)
  • Refactor configureNavRoute to be recursive so that it can handle the nesting menus
  • Refactor NavSideBar to also be recursive so it can handle nesting menus
  • Restore cypress component tests. Parts of this got lost during the unified fides effort. Component tests are really great for testing out just one component and passing it data that our app doesn't (for instance, we can have the component test test out 3 level nesting, while our app currently only does 2 level nesting). They also seem to be way faster than a full cypress test

Steps to Confirm

  • Run the fidesplus backend and npm run dev the admin ui
  • You should now see "Privacy notices" nested under "Consent"
  • You can also run cypress component testing via npm run cy:open then clicking on "Component testing" when it gives you a choice. This lets you see this functionality tested to beyond just one level such as:

image

Pre-Merge Checklist

Description Of Changes

image

@cypress
Copy link

cypress bot commented Apr 18, 2023

Passing run #1464 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 928444f into 45e7ab4...
Project: fides Commit: 3ec66e3819 ℹ️
Status: Passed Duration: 00:36 💡
Started: Apr 20, 2023 5:15 PM Ended: Apr 20, 2023 5:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The component testing in cypress looks nice

@allisonking allisonking merged commit 8416657 into main Apr 20, 2023
@allisonking allisonking deleted the aking/fidesplus-737/side-children-nav branch April 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants