Allow side nav bar to take children elements #3099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/737
Code Changes
NavConfigRoute
to itself also takeNavConfigRoute
as one of its props. This allows infinite nesting of side navigation menus (I doubt we'll go beyond 2 or even 3, but you never know!)configureNavRoute
to be recursive so that it can handle the nesting menusNavSideBar
to also be recursive so it can handle nesting menusSteps to Confirm
npm run dev
the admin uinpm run cy:open
then clicking on "Component testing" when it gives you a choice. This lets you see this functionality tested to beyond just one level such as:Pre-Merge Checklist
CHANGELOG.md
Description Of Changes