-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Privacy Experiences Tables and GET List #3146
Conversation
… and PrivacyExperienceHistories. - Same as privacy notices, when we create an Experience, preserve the history in the history table. - When we update privacy experiences, bump the version, and similarly save off the historical record. - Add an API endpoint to get privacy experiences with associated notices and various filters.
Passing run #1606 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3146 +/- ##
==========================================
+ Coverage 87.51% 87.62% +0.10%
==========================================
Files 309 313 +4
Lines 18010 18178 +168
Branches 2341 2347 +6
==========================================
+ Hits 15762 15929 +167
Misses 1822 1822
- Partials 426 427 +1
☔ View full report in Codecov by Sentry. |
@allisonking when you get a chance could you review this privacy experiences foundation? It's getting large so I'm trying to just add the tables and GET List endpoint here. I'll add the create/update/detail endpoints/update postman collection in the follow up. The main thing to review are if the fields are sufficient to capture what is needed for experiences. The logic itself is almost identical to the work we already did for privacy notices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good @pattisdr ! left some comments as I'm trying to form a clearer picture in my head, but they might just be me not fully understanding things yet 😄
src/fides/api/ctl/migrations/versions/e92da354691e_privacy_experiences.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
Thank you for reviewing and your helpful comments @allisonking I'll start next on trying to get endpoints for these to create/update so this is more easily tested! |
Closes #3019
❗ Contains migration
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Add the backend starting foundation experiences, tables, create/update methods and an initial GET list endpoint.