-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3037 support privacy declaration resource type for custom fields #3149
3037 support privacy declaration resource type for custom fields #3149
Conversation
Passing run #1562 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
- Coverage 87.51% 87.48% -0.04%
==========================================
Files 309 309
Lines 17993 17925 -68
Branches 2337 2325 -12
==========================================
- Hits 15746 15681 -65
+ Misses 1821 1820 -1
+ Partials 426 424 -2
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@SteveDMurphy since you've touched some custom fields work, thought you may be good to review this? a real small change in |
f51bd23
to
c6d5a9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These ones are tough to test for sure! Also feels like there have been 1-2 migration changes per day making it hard to keep them aligned and not blocking each other in flight 🥴 looks good for me locally and runs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @adamsachs
❗ Contains migration; check downrev before merge
partially closes #3037
there will need to be some follow up changes on the fidesplus API side to make this fully work, but these are the necessary updates in
fides
Code Changes
resource_type
enum forCustomFieldDefinition
andCustomField
tables/models to allowprivacy_declaration
as a valueCustomField
s andCustomFieldDefinition
s) that have theprivacy_declaration
as theirresource_type
Steps to Confirm
privacy_declaration
value to theresourcetypes
enumfidesplus
Pre-Merge Checklist
CHANGELOG.md