Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make name not required on privacy declaration #3150

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

adamsachs
Copy link
Contributor

follow up to #3098

per conversation with @NevilleS we're actually trying to move away from relying on the name property, so we shouldn't require it on the BE, even if we do want to use it as part of the uniqueness criteria.

i decided to update the migration in-place since the original PR was merged minutes ago...are we OK with that??

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs marked this pull request as ready for review April 25, 2023 01:16
@cypress
Copy link

cypress bot commented Apr 25, 2023

Passing run #1551 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 996fa37 into d984bd6...
Project: fides Commit: a00e1cb193 ℹ️
Status: Passed Duration: 00:36 💡
Started: Apr 25, 2023 1:30 AM Ended: Apr 25, 2023 1:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d984bd6) 87.47% compared to head (996fa37) 87.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3150   +/-   ##
=======================================
  Coverage   87.47%   87.48%           
=======================================
  Files         309      309           
  Lines       17924    17924           
  Branches     2325     2325           
=======================================
+ Hits        15679    15680    +1     
+ Misses       1821     1820    -1     
  Partials      424      424           
Impacted Files Coverage Δ
src/fides/api/ctl/sql_models.py 98.26% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamsachs adamsachs merged commit 01ea9b4 into main Apr 25, 2023
@adamsachs adamsachs deleted the 3036-follow-up-privacy-dec-name-not-required branch April 25, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants