Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an automated test to check for /fides-consent.js backwards compatibility #3289

Merged
merged 4 commits into from
May 12, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented May 11, 2023

Code Changes

  • Add Cypress test to check that /fides-consent.js returns the same bundle as /fides.js

Steps to Confirm

  • All automated tests succeed

Pre-Merge Checklist

Description Of Changes

This is something I should have added in a previous PR but just occurred to me today - a very quick test to ensure that we maintain backwards compatibility with the fides-consent.js name 👍

@cypress
Copy link

cypress bot commented May 11, 2023

Passing run #1928 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1d2196f into 8b0fd67...
Project: fides Commit: fa1a3cb7a0 ℹ️
Status: Passed Duration: 01:01 💡
Started: May 12, 2023 1:09 PM Ended: May 12, 2023 1:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS NevilleS force-pushed the ns-add-fides-consent-js-compat-test branch from 10720ae to b24d0e9 Compare May 11, 2023 21:44
@NevilleS NevilleS force-pushed the ns-add-fides-consent-js-compat-test branch from b24d0e9 to 1d2196f Compare May 12, 2023 12:51
@NevilleS NevilleS merged commit 4e2b6ff into main May 12, 2023
@NevilleS NevilleS deleted the ns-add-fides-consent-js-compat-test branch May 12, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants