Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use css variables that match brandable color palette #3321

Merged
merged 44 commits into from
May 22, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 17, 2023

Closes #3258

Code Changes

  • Add new CSS vars that match the design
  • Use these CSS vars instead of the old ones for both the banner and modal components
  • Update banner to look a bit more like the designs (two "primary" buttons)
  • Update cypress test

Steps to Confirm

Pre-Merge Checklist

Description Of Changes

Default colors

image

Green colors

image

By setting these vars:

--fides-consent-overlay-primary-color: #398132;
--fides-consent-overlay-primary-button-background-color: #398132;
--fides-consent-overlay-secondary-button-border-color: #398132;
--fides-consent-overlay-primary-active-color: #398132;

Tomato life 🍅

image

@cypress
Copy link

cypress bot commented May 17, 2023

Passing run #2106 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a8fcf67 into 00caa4c...
Project: fides Commit: 739478be16 ℹ️
Status: Passed Duration: 00:43 💡
Started: May 22, 2023 4:50 PM Ended: May 22, 2023 4:51 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review May 17, 2023 22:12
Base automatically changed from aking/3162/pc-experience to main May 19, 2023 18:34
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some conflicts with main, otherwise looks great!

clients/fides-js/src/lib/overlay.module.css Show resolved Hide resolved
@allisonking allisonking merged commit 28f5b3c into main May 22, 2023
@allisonking allisonking deleted the aking/3258/css-variables branch May 22, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor consent components to use CSS variables that match the brandable colour palette from designs
3 participants