-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use css variables that match brandable color palette #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2106 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
commented
May 17, 2023
allisonking
commented
May 17, 2023
NevilleS
reviewed
May 17, 2023
allisonking
force-pushed
the
aking/3258/css-variables
branch
from
May 18, 2023 13:35
b7b7704
to
d7433f1
Compare
allisonking
force-pushed
the
aking/3258/css-variables
branch
from
May 19, 2023 14:45
61b164c
to
fe4008f
Compare
eastandwestwind
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some conflicts with main
, otherwise looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3258
Code Changes
Steps to Confirm
npm run dev-pc
from theclients
directoryoverlay.module.css
to whatever you'd likenpm run dev-pc
and check http://localhost:3000/fides-js-components-demo.html to make sure your changes took placePre-Merge Checklist
CHANGELOG.md
Description Of Changes
Default colors
Green colors
By setting these vars:
Tomato life 🍅