[Backend] Out of the Box Privacy Notices #3401
Conversation
…g the template, and then again when creating the notice from the template. - Also no need to escape "origin" field - Fix typos in template - Assert experiences also created for notices on load - Don't load default notices in test mode
Passing run #2434 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
==========================================
- Coverage 87.14% 87.13% -0.02%
==========================================
Files 312 312
Lines 18724 18787 +63
Branches 2379 2389 +10
==========================================
+ Hits 16317 16370 +53
- Misses 1984 1993 +9
- Partials 423 424 +1
☔ View full report in Codecov by Sentry. |
Conflicts: src/fides/api/api/v1/endpoints/privacy_notice_endpoints.py
pattisdr
changed the title
- Bump migration downrev - Update "personalization" data use to "personalize"
pattisdr
changed the title
|
Out of the box experience configs were just merged which conflicts in several locations. Getting this up-to-date now. |
Conflicts: CHANGELOG.md src/fides/api/app_setup.py src/fides/api/util/consent_util.py tests/ops/util/test_consent_util.py
There was a problem hiding this comment.
nice work @pattisdr , this is pretty straightforward! special thanks for all your annotations with comments, it definitely helped reading through things.
just a few minor comments that you could look into, i don't think any of them are blockers. i think you're right that likely the riskiest/trickiest thing here is integrating your new use case into all that pretty nasty update logic -- as far as i can tell, you've done a nice job with that, and have kept things about as simple as they can be!
…r country codes for now. - Add an alias for PrivacyNoticeTemplate + PrivacyNotice - Relocate test now that method has moved
|
Preemptively merging @adamsachs so I can make the changes to #3465 tonight - happy to address any more followups there. |
yeah of course! didn't mean to suggest this should hold things up. thanks for confirming 👍 |
Closes #2833
❗ Contains migration; check downrev before merge
Description Of Changes
Loads some out of the box privacy notices on startup. Also creates the "experiences" for these notices behind the scenes
Out of the box copy here
Relates to out of the box Experience Configs
Code Changes
data/privacy_notices/privacy_notice_templates.ymlfile into the PrivacyNoticeTemplates fileSteps to Confirm
nox -s dev -- shell2023-05-30 22:52:43.877 [INFO] (consent_util:load_default_notices_on_startup:462): Loading default privacy notice templates from /fides/data/privacy_notices/privacy_notice_templates.yml{{host}}/privacy-notice?systems_applicable=false&show_disabled=trueto see the automatically created privacy_notices. If "origin" is not null, then that notice was created from a template.Pre-Merge Checklist
CHANGELOG.md