Add notice key field to privacy notice form #3403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3344
Code Changes
NoticeKeyField
which watches for changes to thename
field and generates a reasonable key from it when creating a new privacy noticesnakeCase
package to facilitate generating the keylodash
import that was in package.json since nothing uses that anymore (ideally we import the subpackages of lodash, not all of lodash)Steps to Confirm
Note: this does not try to handle the case of what happens if a user edits their notice name, then updates their notice key, then updates their notice name again. This will currently write over the notice key (see first video) which may or may not be what we want. But I didn't want this to get too opinionated without others' input 😄
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
When creating a new privacy notice:
Screen.Recording.2023-05-30.at.8.11.27.PM.mov
When editing a privacy notice name:
Screen.Recording.2023-05-30.at.8.13.51.PM.mov