Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection configuration to the system portal #3407

Merged
merged 80 commits into from
Jun 8, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented May 31, 2023

Closes #3370, Closes #3372, Closes #3375, Closes #3373

Code Changes

  • Remove some hand made types that are now covered by the autogenerated types ( more/all will be removed once the original connection config page is completely removed)
  • Add Integrations tab for configuring connections
  • Refactored the entire connection config tab flow into a more streamlined version that shares the same component instead of having copies of the same component with 95% the same logic.
    • This update also converts everything to be a proper formik form/field.

Steps to Confirm

Note
All of the connection config operations are done within the system portal integrations tab. In the future connection configuration will only be done in the system portal. Now it's still possible to created "unlinked" or "orphaned" connections from the original page. This is helpful for testing the new Linked unlinked connector button.

Note
All of the CRUD checks below assume creating a new system

  • Run nox -s dev in fides and turbo run dev in /clients/admin
  • Database connector
    • Create
    • Edit
    • Delete
    • Verify that a dataset can only be created with the YAML editor when one isn't already linked to the connector
    • Verify that the dataset YAML editor is read only when editing
    • Check that switching the dataset with the dropdown "works". (If it errors that's expected)
  • Saas connector
    • Create
    • Edit
    • Delete
    • Verify that the connector is only able to select new datasets from the dropdown. The YAML editor should always be read only
    • Check that switching the dataset with the dropdown "works". (If it errors that's expected)
  • Email connector
    • Create
    • Edit
    • Delete
  • Manual connector
    • Create
    • Edit
    • Delete
    • Check that the "Customize DSR" button shows up when editing. Verify that creating, retrieving, and editing DSR fields works
  • Verify that uploading connector templates works
  • Link unlinked connectors button
    • Verify that it only shows up when there are unlinked connectors
    • Verify that linking an unlinked connector links it to the system and removes it from the unlinked connectors list

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@TheAndrewJackson TheAndrewJackson self-assigned this May 31, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +29.80 🎉

Comparison is base (e9f3ed6) 56.99% compared to head (68e4a2f) 86.80%.

❗ Current head 68e4a2f differs from pull request most recent head d202a85. Consider uploading reports for the commit d202a85 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3407       +/-   ##
===========================================
+ Coverage   56.99%   86.80%   +29.80%     
===========================================
  Files         311      312        +1     
  Lines       18800    18813       +13     
  Branches     2395     2397        +2     
===========================================
+ Hits        10715    16330     +5615     
+ Misses       7852     2065     -5787     
- Partials      233      418      +185     
Impacted Files Coverage Δ
src/fides/api/ctl/routes/system.py 92.64% <100.00%> (+11.76%) ⬆️
src/fides/api/ctl/schemas/system.py 100.00% <100.00%> (ø)
src/fides/api/ctl/sql_models.py 97.73% <100.00%> (+2.69%) ⬆️
src/fides/api/util/connection_util.py 92.70% <100.00%> (+43.77%) ⬆️

... and 164 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheAndrewJackson TheAndrewJackson changed the base branch from 3263-system-connections to main June 7, 2023 18:27
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the duplicate enabled_actions in db_dataset.yml and we're good to go

@TheAndrewJackson TheAndrewJackson merged commit a343404 into main Jun 8, 2023
@TheAndrewJackson TheAndrewJackson deleted the 3276_ajackson_add_connections_to_system_portal branch June 8, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants