Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe sign access request test #3504

Merged
merged 17 commits into from
Aug 15, 2023
Merged

Adobe sign access request test #3504

merged 17 commits into from
Aug 15, 2023

Conversation

ctvivek
Copy link
Contributor

@ctvivek ctvivek commented Jun 8, 2023

Closes #1295

Code Changes

NEW SaaS Connector Adobe Sign for access

Steps to Confirm

  • Add/configure the Adobe Sign connector in UI
  • Verify Adobe Sign config and icon UI looks good
    image
  • Create an Access DSR with the new Adobe Sign customer email
  • Verify email sent by fides with customer data is correct
image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access Test Passing
  • Icon

@cypress
Copy link

cypress bot commented Jun 8, 2023

Passing run #3467 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge a2fba60 into d47236e...
Project: fides Commit: 6fb86c3150 ℹ️
Status: Passed Duration: 00:56 💡
Started: Aug 2, 2023 4:52 PM Ended: Aug 2, 2023 4:53 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (d47236e) 86.95% compared to head (a2fba60) 86.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3504   +/-   ##
=======================================
  Coverage   86.95%   86.96%           
=======================================
  Files         317      317           
  Lines       19393    19402    +9     
  Branches     2493     2497    +4     
=======================================
+ Hits        16864    16872    +8     
+ Misses       2102     2101    -1     
- Partials      427      429    +2     
Files Changed Coverage Δ
...ocessor_strategy/post_processor_strategy_filter.py 92.98% <88.88%> (-0.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved knowing you will fix the little git issue

data/saas/config/adobe_sign_config.yml Outdated Show resolved Hide resolved
@galvana galvana merged commit 3f1ebeb into main Aug 15, 2023
11 of 13 checks passed
@galvana galvana deleted the adobe-sign-test branch August 15, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adobe Sign
3 participants