Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing workflow optimizations #3526

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Jun 9, 2023

Closes #3525

Code Changes

  • only push :dev tagged images on untagged commits to main or unrecognized git tags, since we have specific image tags (:prerelease, :rc) published for our recognized git tags
  • trigger fidesinfra RC environment redeployments when rc images are published here in fides. since this job may take longer than the downstream RC publishing job in fidesplus, this keeps the RC environment well up to date in those race conditions, with no manual intervention required.
  • only trigger the fidesplus integrated prerelease image build/publish on alpha git tags pushed here in fides; previously, we were triggering this build with rc tags published here in fides which ultimately caused some rc code to make its way on the prerelease environment and led to some confusion

Steps to Confirm

  • we can confirm the first change by pushing an alpha tag on this branch and ensuring a :dev tagged image isn't published
  • i think the other changes will require rc tags and release branches to confirm. if we want to "fake" that, we could - but let's not get in the way of real release testing ongoing now...so we should hold off on it!

Pre-Merge Checklist

Description Of Changes

the main motivation behind these changes is trying to reduce the amount of manual intervention and wait times needed in the release process to get new RC images after code is merged.

a broader motivation is that we're trying to reduce wait times on the docker publishing action generally - this PR should help us by not pushing :dev images on commits with recognized tag. note that #3492 should also help a lot with action run times - though for a totally separate reason!

@cypress
Copy link

cypress bot commented Jun 9, 2023

Passing run #2610 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0c2b620 into e4078a7...
Project: fides Commit: 0a578e83c6 ℹ️
Status: Passed Duration: 01:13 💡
Started: Jun 9, 2023 10:13 PM Ended: Jun 9, 2023 10:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4078a7) 87.17% compared to head (0c2b620) 87.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3526   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         311      311           
  Lines       18803    18803           
  Branches     2395     2395           
=======================================
  Hits        16391    16391           
  Misses       1990     1990           
  Partials      422      422           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamsachs adamsachs self-assigned this Jun 9, 2023
@adamsachs adamsachs force-pushed the asachs-publishing-optimizations branch from 6f2fc2b to 0c2b620 Compare June 9, 2023 21:51
@adamsachs adamsachs marked this pull request as ready for review June 9, 2023 21:51
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization!

@ThomasLaPiana ThomasLaPiana merged commit 1ba9953 into main Jun 12, 2023
@ThomasLaPiana ThomasLaPiana deleted the asachs-publishing-optimizations branch June 12, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misc. publishing workflow optimizations
2 participants