-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fides-js
and privacy center cookie enforcement
#3569
Merged
allisonking
merged 12 commits into
fides_3478_system_cookies
from
aking/3500/fides-js-cookie-enforcement
Jun 21, 2023
Merged
fides-js
and privacy center cookie enforcement
#3569
allisonking
merged 12 commits into
fides_3478_system_cookies
from
aking/3500/fides-js-cookie-enforcement
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
commented
Jun 15, 2023
allisonking
commented
Jun 15, 2023
allisonking
commented
Jun 15, 2023
allisonking
commented
Jun 15, 2023
allisonking
force-pushed
the
aking/3500/fides-js-cookie-enforcement
branch
from
June 19, 2023 16:42
e06eafe
to
b5071c2
Compare
Passing run #2848 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
force-pushed
the
aking/3500/fides-js-cookie-enforcement
branch
from
June 20, 2023 16:02
7826a09
to
c2cd1d8
Compare
Kelsey-Ethyca
approved these changes
Jun 21, 2023
Love all the refactoring you did along the way! |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3500 and closes #3501
Code Changes
removeCookiesFromBrowser
function + unit testsupdateConsentPreferences
function to call this on notices that have been opted out ofremoveCookiesFromBrowser
on notices that have been opted out ofSteps to Confirm
Privacy center
nox -s dev
andturbo dev
in theadmin-ui
directoryadmin-ui
, add a system that has a data usemarketing.advertising.first_party.targeted
and add a cookie called i.e.test
nox -s dev
turbo dev
in theprivacy-center
directorytest
at path/
test
is removedFides-js
/fides-js-demo-components.html
testCookie
via dev toolsPre-Merge Checklist
CHANGELOG.md
Description Of Changes
https://www.loom.com/share/436d1c41f9384c30826b79857e7d7d69?sid=f5a52f9b-9a1e-4731-b647-142e534bb9ef