Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fides-js and privacy center cookie enforcement #3569

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 15, 2023

Closes #3500 and closes #3501

Code Changes

  • Add a new removeCookiesFromBrowser function + unit tests
  • Update our updateConsentPreferences function to call this on notices that have been opted out of
  • Update privacy center's save function to also call removeCookiesFromBrowser on notices that have been opted out of
  • Cypress tests

Steps to Confirm

Privacy center

  • First, checkout this branch Data use cookie field #3571 so that you can input cookies onto a system
  • Run nox -s dev and turbo dev in the admin-ui directory
  • In the admin-ui, add a system that has a data use marketing.advertising.first_party.targeted and add a cookie called i.e. test
  • Now checkout this branch. No need to restart nox -s dev
  • Run turbo dev in the privacy-center directory
  • Navigate to the privacy center and click on the consent tile and enter an email
  • You should see "Data Sales and Sharing"
  • Now add a cookie via Chrome dev tools called test at path /
  • Opt out of "Data Sales and Sharing"
  • Confirm the cookie test is removed

Fides-js

  • Run the privacy center, then navigate to /fides-js-demo-components.html
  • Add a cookie called testCookie via dev tools
  • Opt out of "Test privacy notice"
  • Observe the cookie disappears

Pre-Merge Checklist

Description Of Changes

https://www.loom.com/share/436d1c41f9384c30826b79857e7d7d69?sid=f5a52f9b-9a1e-4731-b647-142e534bb9ef

@allisonking allisonking force-pushed the aking/3500/fides-js-cookie-enforcement branch from e06eafe to b5071c2 Compare June 19, 2023 16:42
@allisonking allisonking changed the base branch from main to fides_3478_system_cookies June 19, 2023 16:44
@cypress
Copy link

cypress bot commented Jun 19, 2023

Passing run #2848 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 73b81d3 into c8493db...
Project: fides Commit: 1d6cdff3c4 ℹ️
Status: Passed Duration: 00:48 💡
Started: Jun 21, 2023 6:29 PM Ended: Jun 21, 2023 6:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking force-pushed the aking/3500/fides-js-cookie-enforcement branch from 7826a09 to c2cd1d8 Compare June 20, 2023 16:02
@allisonking allisonking marked this pull request as ready for review June 20, 2023 16:34
@Kelsey-Ethyca
Copy link
Contributor

Love all the refactoring you did along the way!

@allisonking allisonking merged commit 2720914 into fides_3478_system_cookies Jun 21, 2023
@allisonking allisonking deleted the aking/3500/fides-js-cookie-enforcement branch June 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Center update to read and delete cookies Privacy component update to read and delete cookies
2 participants