Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurveyMonkey - Access and Erasure #3590

Merged
merged 11 commits into from
Jun 20, 2023
Merged

SurveyMonkey - Access and Erasure #3590

merged 11 commits into from
Jun 20, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 16, 2023

Closes #1882

Code Changes

Access, erasure, and consent support for SurveyMonkey

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
image
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct
image

Pre-PR checklist

  • Secrets added to 1Password
    • Values for connector_params
    • Any identity values, such as identity_email or identity_phone_number
  • Postman collection
    • All requests in the SaaS config
    • All requests to create test data
  • Access tests passing
  • Erasure tests passing

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md
  • Icon

@cypress
Copy link

cypress bot commented Jun 16, 2023

Passing run #2768 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 35a203f into 9cddb24...
Project: fides Commit: 1f22fff407 ℹ️
Status: Passed Duration: 00:58 💡
Started: Jun 16, 2023 9:43 PM Ended: Jun 16, 2023 9:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0fe6941) 87.06% compared to head (35a203f) 87.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   87.06%   87.06%   -0.01%     
==========================================
  Files         312      310       -2     
  Lines       19001    18988      -13     
  Branches     2422     2421       -1     
==========================================
- Hits        16544    16532      -12     
  Misses       2028     2028              
+ Partials      429      428       -1     

see 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana merged commit 22689ca into main Jun 20, 2023
@galvana galvana deleted the survey-monkey-test branch June 20, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey Monkey
3 participants