Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurly access #3595

Merged
merged 15 commits into from
Aug 1, 2023
Merged

Recurly access #3595

merged 15 commits into from
Aug 1, 2023

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented Jun 16, 2023

Closes #1330

Code Changes
Access support for Recurly

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-PR checklist

  • Secrets added to 1Password
    • Values for connector_params
    • Any identity values, such as identity_email or
      identity_phone_number
  • Postman collection
    • All requests in the SaaS config
    • All requests to create test data
  • Access tests passing

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md
  • Icon

@cypress
Copy link

cypress bot commented Jun 16, 2023

Passing run #3446 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 7be7036 into 8659d74...
Project: fides Commit: 22c869d85b ℹ️
Status: Passed Duration: 01:13 💡
Started: Aug 1, 2023 12:24 PM Ended: Aug 1, 2023 12:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8659d74) 86.95% compared to head (7be7036) 86.95%.

❗ Current head 7be7036 differs from pull request most recent head 791117f. Consider uploading reports for the commit 791117f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3595   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files         317      317           
  Lines       19398    19398           
  Branches     2494     2494           
=======================================
  Hits        16867    16867           
  Misses       2103     2103           
  Partials      428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana changed the title Recurly access and erasure test Recurly access Jul 31, 2023
@galvana galvana merged commit eccf7b8 into main Aug 1, 2023
11 of 12 checks passed
@galvana galvana deleted the recurly-access-muralikrishnan branch August 1, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurly
2 participants