-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Remove Automatic SafeStr serialization from PrivacyExperienceConfig. #3600
Conversation
- Escape experience configs before saving in the db. Unescape before returning. - Unescape embedded experience configs and privacy notices in the PrivacyExperience response - Unescape notices in the response before returning after create and update.
# Conflicts: # src/fides/api/api/v1/endpoints/connection_endpoints.py
Passing run #2780 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
…d tests - note that we don't have to unescape the description because it doesn't show up in the email.
@allisonking requesting your review because I believe it was your pattern I followed from notices! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
+ Coverage 86.66% 87.06% +0.40%
==========================================
Files 310 310
Lines 18988 19002 +14
Branches 2421 2427 +6
==========================================
+ Hits 16455 16544 +89
+ Misses 2107 2029 -78
- Partials 426 429 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works great! we'll need to pass the special header in privacy center and fides-js too, otherwise it looks like this 😅
ticket here: #3606
but works great in admin-ui which is passing the header!
Closes #3301
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Strings that are escaped on ExperienceConfigs are currently surfaced in their escaped form.