Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest asyncpg dependency #3614

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Jun 19, 2023

Closes #3613

Code Changes

  • update to latest asyncpg dependency to avoid build error

Steps to Confirm

  • our images build
  • no regressions (🤞 for good automated test coverage!)

Pre-Merge Checklist

Description Of Changes

See issue description for a synopsis of why this is just now biting us, it's been lurking for a while!

@adamsachs adamsachs linked an issue Jun 19, 2023 that may be closed by this pull request
@adamsachs
Copy link
Contributor Author

adamsachs commented Jun 19, 2023

this is obviously a straightforward change to get us past a build error.

@ThomasLaPiana and @pattisdr just figured you two would be the best suited to know whether updating asyncpg could have some hidden issue, and @allisonking you reported this so also wanted to make sure it looked alright to you!

i've got a changelog update queued up but just gonna hold off on a push to i can see CI go green first 😅

@cypress
Copy link

cypress bot commented Jun 19, 2023

Passing run #2786 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9d267dd into eb400e1...
Project: fides Commit: 41bbbb6b3d ℹ️
Status: Passed Duration: 00:47 💡
Started: Jun 19, 2023 10:28 PM Ended: Jun 19, 2023 10:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eb400e1) 87.06% compared to head (9d267dd) 87.06%.

❗ Current head 9d267dd differs from pull request most recent head 5f3eec3. Consider uploading reports for the commit 5f3eec3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3614   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         310      310           
  Lines       19002    19002           
  Branches     2427     2427           
=======================================
  Hits        16544    16544           
  Misses       2029     2029           
  Partials      429      429           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the build error for me! Thanks @adamsachs

@adamsachs adamsachs marked this pull request as ready for review June 19, 2023 23:39
@adamsachs adamsachs merged commit 2834895 into main Jun 19, 2023
@adamsachs adamsachs deleted the 3613-asyncpg==0250-is-causing-build-errors branch June 19, 2023 23:41
@pattisdr
Copy link
Contributor

Also verified that this fixed things, thanks for your work here!

@vittoriozamboni
Copy link

Thanks @adamsachs , I had this error in another project and took me a while to get it was asyncpg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asyncpg==0.25.0 is causing build errors
4 participants