Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookies before marshalling to privacy notice form #3670

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 24, 2023

Closes #3672

Description Of Changes

The privacy notice endpoint is strict about what fields get passed into its PUT. Since we added a cookies field recently, this was actually getting passed back into the endpoint, though it's not allowed. This PR adds cookies to the list of fields to remove before handling the form.

Code Changes

  • Removes cookies from the form object
  • Updates Cypress test so it will make sure we are only sending the values we expect

Steps to Confirm

  • See issue steps

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jun 24, 2023

Passing run #2899 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 79bd302 into c55abb0...
Project: fides Commit: 95a16b192f ℹ️
Status: Passed Duration: 00:56 💡
Started: Jun 24, 2023 12:42 AM Ended: Jun 24, 2023 12:43 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review June 26, 2023 14:08
@allisonking allisonking merged commit a081a87 into main Jun 26, 2023
@allisonking allisonking deleted the aking/privacy-notice-edit branch June 26, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release bug: Error when updating privacy notice
2 participants