-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update front-end to treat fields with default values as required #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2998 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
galvana
commented
Jun 28, 2023
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Outdated
Show resolved
Hide resolved
TheAndrewJackson
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Once the CI checks are all passing this is good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/961
Description Of Changes
Updating the conditions to validate and flag a field as required. Using the presence of a default value to determine that a field is required.
Code Changes
ConnectorParametersForm
under the system page. Skipped making the change for the previous connector manager page since we're phasing that out.Steps to Confirm
domain
field should be required even though it has a default value.Pre-Merge Checklist
CHANGELOG.md