Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front-end to treat fields with default values as required #3694

Merged
merged 10 commits into from
Jun 29, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 28, 2023

Closes https://github.com/ethyca/fidesplus/issues/961

Description Of Changes

Updating the conditions to validate and flag a field as required. Using the presence of a default value to determine that a field is required.

Code Changes

  • Updated the ConnectorParametersForm under the system page. Skipped making the change for the previous connector manager page since we're phasing that out.

Steps to Confirm

  • I used Aircall as an example, the domain field should be required even though it has a default value.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #2998 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3df7d43 into cd579f7...
Project: fides Commit: 08148a0ab3 ℹ️
Status: Passed Duration: 00:44 💡
Started: Jun 29, 2023 10:02 PM Ended: Jun 29, 2023 10:03 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana marked this pull request as ready for review June 28, 2023 23:00
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Once the CI checks are all passing this is good to go

@galvana galvana merged commit f63a843 into main Jun 29, 2023
@galvana galvana deleted the 961-make-default-fields-required branch June 29, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants