Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3601: test connection results toast #3700

Merged
merged 12 commits into from
Jun 30, 2023
Merged

3601: test connection results toast #3700

merged 12 commits into from
Jun 30, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jun 28, 2023

Closes #3601

Description Of Changes

Removed test connection box below "Test connection" button and replaced it with success or failure toasts, depending on result of test.

Success example:

Screenshot 2023-06-28 at 5 42 38 PM

Failure example:

Screenshot 2023-06-28 at 5 41 10 PM

Code Changes

  • Repurposed old TestConnection component to be a standalone component for the toast
  • Changed HandleTestConnectionClick method in ConnectorParametersForm to prevent the method from being run repeatedly; errors are now handled by toasting in the ConnectorParameters above

Steps to Confirm

  1. From the "Configure your system" view in "Data map", navigate to the "Integrations" tab
  2. Add valid credentials to the connection, then click "Test connection"; note toast and no test result box at bottom of page
  3. Change connection credentials to be invalid, then click "Test connection" again; note toast and no test result box at bottom of page

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@jpople jpople requested a review from allisonking June 28, 2023 21:46
@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #3020 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5b37f6a into 0ded7e8...
Project: fides Commit: d880fcf705 ℹ️
Status: Passed Duration: 00:49 💡
Started: Jun 30, 2023 8:58 PM Ended: Jun 30, 2023 8:59 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be pretty complicated for a toast, didn't it? 😄 nice job tackling it, just a few suggestions, and one bigger thing that might need to be rolled out into its own ticket

@jpople jpople requested a review from allisonking June 30, 2023 18:19
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job turning this around!! left a very nit comment. other than that, can you make a follow up issue out of this bug we talked about? you can add it to the roadmap team project, and also assign it to the next sprint (doesn't mean it'll get worked on next sprint, but gives product a chance to see the ticket and decide its priority!)

@jpople jpople merged commit 1212ead into main Jun 30, 2023
@jpople jpople deleted the 3601-test-connection-toasts branch June 30, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add success and failure toasts when clicking test connection
2 participants