-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3601: test connection results toast #3700
Conversation
Passing run #3020 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this turned out to be pretty complicated for a toast, didn't it? 😄 nice job tackling it, just a few suggestions, and one bigger thing that might need to be rolled out into its own ticket
...nts/admin-ui/src/features/datastore-connections/system_portal_config/TestConnectionToast.tsx
Outdated
Show resolved
Hide resolved
...nts/admin-ui/src/features/datastore-connections/system_portal_config/TestConnectionToast.tsx
Outdated
Show resolved
Hide resolved
...min-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Show resolved
Hide resolved
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job turning this around!! left a very nit comment. other than that, can you make a follow up issue out of this bug we talked about? you can add it to the roadmap team project, and also assign it to the next sprint (doesn't mean it'll get worked on next sprint, but gives product a chance to see the ticket and decide its priority!)
Closes #3601
Description Of Changes
Removed test connection box below "Test connection" button and replaced it with success or failure toasts, depending on result of test.
Success example:
Failure example:
Code Changes
TestConnection
component to be a standalone component for the toastHandleTestConnectionClick
method inConnectorParametersForm
to prevent the method from being run repeatedly; errors are now handled by toasting in theConnectorParameters
aboveSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md