Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show/hide connector values #3775

Merged
merged 32 commits into from
Jul 18, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 11, 2023

Closes #3380

Description Of Changes

Update fides to return connection config secrets by default. It will ALWAYS mask sensitive secret values by utilizing the secret schema. Sensitive values will be return as **********.

This allows the admin ui to display the non sensitive secrets and the masked sensitive secrets in the integration configuration page. It improves the UX by showing the user that the secrets are configured instead of always showing blank input fields.

Code Changes

  • Return connection config secrets. The sensitive secrets are masked!
  • Add a new secrets patch endpoint nested under /system that only updates secret values that were included in the payload. This is so sensitive secrets don't get overwritten with ********** values.
  • Update the admin to show secrets and in the UI and use the new patch endpoint

Steps to Confirm

  • run fides and the admin ui
  • create a system
  • add an integration to that system that have sensitive values. Like Aircall for example
  • Confirm that the sensitive values are masked in the response

Pre-Merge Checklist

A lot of code needed to reorganized to avoid circular dependencies
@cypress
Copy link

cypress bot commented Jul 11, 2023

Passing run #3190 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c035b1e into e9aeaf0...
Project: fides Commit: 5a9659e678 ℹ️
Status: Passed Duration: 01:08 💡
Started: Jul 18, 2023 1:58 PM Ended: Jul 18, 2023 2:00 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 86.61% and project coverage change: +1.83 🎉

Comparison is base (e9aeaf0) 85.39% compared to head (720c67c) 87.23%.

❗ Current head 720c67c differs from pull request most recent head c035b1e. Consider uploading reports for the commit c035b1e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
+ Coverage   85.39%   87.23%   +1.83%     
==========================================
  Files         311      315       +4     
  Lines       19222    19291      +69     
  Branches     2470     2479       +9     
==========================================
+ Hits        16415    16828     +413     
+ Misses       2369     2033     -336     
+ Partials      438      430       -8     
Impacted Files Coverage Δ
src/fides/api/api/v1/endpoints/system.py 79.34% <33.33%> (-13.71%) ⬇️
...emas/connection_configuration/connection_config.py 96.29% <90.62%> (-3.71%) ⬇️
...fides/api/api/v1/endpoints/connection_endpoints.py 91.66% <100.00%> (+3.12%) ⬆️
.../api/api/v1/endpoints/connection_type_endpoints.py 100.00% <100.00%> (ø)
...ides/api/api/v1/endpoints/saas_config_endpoints.py 85.71% <100.00%> (+0.11%) ⬆️
src/fides/api/db/seed.py 92.00% <100.00%> (+0.04%) ⬆️
...ection_configuration/connection_type_system_map.py 100.00% <100.00%> (ø)
...emas/connection_configuration/enums/system_type.py 100.00% <100.00%> (ø)
...emas/connection_configuration/enums/test_status.py 100.00% <100.00%> (ø)
...ction_configuration/saas_config_template_values.py 100.00% <100.00%> (ø)
... and 3 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 14, 2023 14:51
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes, I'm glad this feature is finally going in!

@TheAndrewJackson TheAndrewJackson merged commit aa76b4b into main Jul 18, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3739_show_connector_values branch July 18, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update front-end to show values and hide sensitive values
2 participants