-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show/hide connector values #3775
Conversation
A lot of code needed to reorganized to avoid circular dependencies
Passing run #3190 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
+ Coverage 85.39% 87.23% +1.83%
==========================================
Files 311 315 +4
Lines 19222 19291 +69
Branches 2470 2479 +9
==========================================
+ Hits 16415 16828 +413
+ Misses 2369 2033 -336
+ Partials 438 430 -8
☔ View full report in Codecov by Sentry. |
src/fides/api/schemas/connection_configuration/connection_config.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the suggested changes, I'm glad this feature is finally going in!
Closes #3380
Description Of Changes
Update fides to return connection config secrets by default. It will ALWAYS mask sensitive secret values by utilizing the secret schema. Sensitive values will be return as
**********
.This allows the admin ui to display the non sensitive secrets and the masked sensitive secrets in the integration configuration page. It improves the UX by showing the user that the secrets are configured instead of always showing blank input fields.
Code Changes
/system
that only updates secret values that were included in the payload. This is so sensitive secrets don't get overwritten with**********
values.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md