Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system connection delete route #3785

Merged
merged 12 commits into from
Jul 19, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 14, 2023

Closes #3739

Description Of Changes

Update the FE to use the delete connection delete route. It also fixes a couple issues with the delete route

Code Changes

  • Update frontend to use new delete route
  • Fix some small issues with the delete route in the BE
  • Update BE tests

Steps to Confirm

  • Run fides and the admin ui
  • create a system and an integration
  • delete the integration

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson self-assigned this Jul 14, 2023
@cypress
Copy link

cypress bot commented Jul 14, 2023

Passing run #3203 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7a34b0e into aa76b4b...
Project: fides Commit: 954eb936d5 ℹ️
Status: Passed Duration: 01:03 💡
Started: Jul 19, 2023 12:01 PM Ended: Jul 19, 2023 12:03 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 17, 2023 19:58
@TheAndrewJackson TheAndrewJackson merged commit 97b7823 into main Jul 19, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3739_update_delete_route branch July 19, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Integration tab to use new delete route
2 participants