Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3644 link connector toast #3826

Merged
merged 5 commits into from
Jul 21, 2023
Merged

3644 link connector toast #3826

merged 5 commits into from
Jul 21, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 19, 2023 •
edited
Loading

Closes #3644

Description Of Changes

Adds a success toast upon linking an orphaned connector to a system from the modal.

Screenshot 2023-07-19 at 10 58 21 AM

Steps to Confirm

  • add a new system
  • add a new connection via the connection manager page
  • click "link integration" on the system page
  • link the integration

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 19, 2023 •
edited
Loading

Passing run #3256 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge f5c479a into 98db649...
Project: fides Commit: d16bc88923 ℹ️
Status: Passed Duration: 00:55 💡
Started: Jul 20, 2023 10:07 PM Ended: Jul 20, 2023 10:08 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople requested a review from allisonking July 19, 2023 15:29
allisonking
allisonking approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, nice job!

@jpople jpople merged commit 639e267 into main Jul 21, 2023
@jpople jpople deleted the 3644-link-connector-toast branch July 21, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need success toast for linking connector
2 participants
@jpople @allisonking