Make taxonomy items able to be enabled or disabled #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3296 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
…egory types; fix cypress tests, change disable modal to not say children;
allisonking
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
nice job working through a complicated feature that touched a lot of parts @jpople !! left a few comments, though I wouldn't consider any of them blocking 👍
clients/admin-ui/src/features/system/privacy-declarations/PrivacyDeclarationStep.tsx
Show resolved
Hide resolved
|
oh but one question: do we need privacy notices to be filtered too? they also have a |
Co-authored-by: Allison King <[email protected]>
Co-authored-by: Allison King <[email protected]>
jpople
added a commit
that referenced
this pull request
Jul 24, 2023
Co-authored-by: Kelsey Thomas <[email protected]> Co-authored-by: Allison King <[email protected]> Co-authored-by: Allison King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3710
Adds a toggle to the hover menu in the taxonomy view for taxonomy items which enables or disables them after displaying a modal. Disabled items will not be shown in system form dropdowns [not implemented yet].
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md