Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor list dropdown #3857

Merged
merged 25 commits into from
Aug 18, 2023
Merged

vendor list dropdown #3857

merged 25 commits into from
Aug 18, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 25, 2023

Closes fidesplus#985

Description Of Changes

Add a new vendor list dropdown for fidesplus that gives users the ability to link a system with an entry from the dictionary service

image

Code Changes

  • Add a new CustomOption component to the CustomSelect form component
  • Update system form to conditionally display the vendor dropdown

Steps to Confirm

OSS

  • run the admin ui and fides
  • create a system
  • verify that the vendor dropdown isn't there
  • edit the system and save. Make sure the saving works

Plus
message @TheAndrewJackson for fidesplus setup

  • run the admin ui and fidesplus
  • create a system
  • verify that the vendor dropdown is there
  • select an option from the vendor dropdown
  • save. make sure it correctly saves.
  • refresh the page and make sure it populates the vendor dropdown

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jul 25, 2023

Passing run #3628 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7d0d1f8 into 2de9db7...
Project: fides Commit: 683c1a3caa ℹ️
Status: Passed Duration: 01:10 💡
Started: Aug 18, 2023 1:13 AM Ended: Aug 18, 2023 1:14 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson self-assigned this Jul 25, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 26, 2023 14:22
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! left some comments, but I haven't tested yet (waiting for instructions for fidesplus setup!)

clients/admin-ui/src/features/plus/types.ts Show resolved Hide resolved
clients/admin-ui/src/features/system/form.ts Outdated Show resolved Hide resolved
clients/admin-ui/src/features/system/form.ts Outdated Show resolved Hide resolved
@TheAndrewJackson
Copy link
Contributor Author

@allisonking I think I've addressed everything from the first round of feedback 👍

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it out and it works great! 😎 would also be nice to have cypress tests for this, though it could wait until things are more stable if you'd prefer!

@TheAndrewJackson TheAndrewJackson merged commit 89488b8 into main Aug 18, 2023
10 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson_vendor_list_dropdown branch August 18, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants