-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor list dropdown #3857
vendor list dropdown #3857
Conversation
Passing run #3628 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! left some comments, but I haven't tested yet (waiting for instructions for fidesplus setup!)
@allisonking I think I've addressed everything from the first round of feedback 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it out and it works great! 😎 would also be nice to have cypress tests for this, though it could wait until things are more stable if you'd prefer!
e7ce804
to
af030c6
Compare
Closes fidesplus#985
Description Of Changes
Add a new vendor list dropdown for fidesplus that gives users the ability to link a system with an entry from the dictionary service
Code Changes
CustomOption
component to theCustomSelect
form componentSteps to Confirm
OSS
Plus
message @TheAndrewJackson for fidesplus setup
Pre-Merge Checklist
CHANGELOG.md