Update Healthcheck logic #3884
Merged
Update Healthcheck logic #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3457 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
After refactoring the database check, ~10ms response time
|
|
with a worker enabled:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3884 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 317 317
Lines 19398 19393 -5
Branches 2494 2493 -1
=======================================
- Hits 16867 16864 -3
+ Misses 2103 2102 -1
+ Partials 428 427 -1
☔ View full report in Codecov by Sentry. |
|
I don't believe any of these test failures are related to these changes |
RobertKeyser
reviewed
Aug 1, 2023
Co-authored-by: Robert Keyser <[email protected]>
SteveDMurphy
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Nice work @ThomasLaPiana ! Looks good and nice use of the existing db health check in get_db_engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2517
Description Of Changes
The
databasehealth check step was found to be extremely heavy, sometimes spiking response times to ~1 sec when running locally with nothing else hitting the serverAfter doing some investigation of the
workerchecks as well, I couldn't find evidence that this was an issue. It only increased processing time by ~6ms. After checking everything I believe that the database was the primary culprit here, but we'll continue to monitor this fix as it is rolled out and verify that conclusion.Code Changes
Steps to Confirm
ipythonand run some tests usingrequeststo get those logs populated, verify the numbers look rightdatabase.pyand force the url to be wrong for the healthcheck function. Ensure that the status is 503 and the error is loggedPre-Merge Checklist
CHANGELOG.md