Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary suggest select #3988

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Dictionary suggest select #3988

merged 4 commits into from
Aug 28, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 28, 2023

Closes #3960

Description Of Changes

Adds a toggle switch and dropdown select which take suggestions from the dictionary.

Steps to Confirm

  • Create a new system
  • In vendor dropdown, select a vendor (I've been using ": Tappx" to test because it transfers data and has options for "legal basis for transfer"
  • Show suggestions
  • "This system transfers data" field should be toggled on, and displaying a select input with "Adequacy decision" and "Standard contractual clauses"

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Aug 28, 2023

Passing run #3769 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d693d0d into 6ca4451...
Project: fides Commit: b110935a7f ℹ️
Status: Passed Duration: 01:36 💡
Started: Aug 28, 2023 8:29 PM Ended: Aug 28, 2023 8:31 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople marked this pull request as ready for review August 28, 2023 20:58
@jpople jpople merged commit 1e66560 into main Aug 28, 2023
10 checks passed
@jpople jpople deleted the 3960-dictionary-suggest-select branch August 28, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dictionary suggestion dropdown
2 participants