Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold consent config page #4069

Merged
merged 12 commits into from
Sep 13, 2023
Merged

Scaffold consent config page #4069

merged 12 commits into from
Sep 13, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 11, 2023

Closes #4051

Description Of Changes

Skeleton of consent configuration page so that we can start building off of it 🚀

image

Empty state (still need copy)
image

Home page tile
image

Code Changes

  • Add a new page with a route for consent configuration + a new flag
  • While we're in the flags code, graduate privacy notices and experiences from beta
  • Add basic modals for adding a vendor and adding a cookie
  • Add a new tile to the home page. Also had to enable feature flagging home tiles
  • Cypress tests

Steps to Confirm

  • Run fidesplus server
  • Run admin-ui
  • Click on "Consent" and you should see a new page "Configure consent" in the side nav. You should be able to click the add vendor and add cookie buttons, and see any systems you have
  • Click on the home page. You should be able to see the "Configure consent" home page tile
  • If you edit flags.json and set "configureConsent"'s development: false, then you should no longer be able to access those pages.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 11, 2023

Passing run #4109 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1f105e4 into 7f53a75...
Project: fides Commit: 5260759e5d ℹ️
Status: Passed Duration: 01:12 💡
Started: Sep 13, 2023 6:40 PM Ended: Sep 13, 2023 6:41 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 12, 2023 00:00
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@allisonking allisonking merged commit b48ed60 into main Sep 13, 2023
10 checks passed
@allisonking allisonking deleted the aking/4051/consent-config-page branch September 13, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold initial page for adding vendors/cookies for consent
2 participants