Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff modal patch #4083

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Diff modal patch #4083

merged 5 commits into from
Sep 14, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Sep 13, 2023

Description Of Changes

Fixing vendor ID field in system change modal and updating the diff modal to say "Change detail" instead of "Diff review"

Steps to Confirm

  • Start fidesplus
  • Create a system and set the vendor ID
  • Make a change to the system
  • Verify the modal title is "Change detail" and that the vendor label is displayed instead of the ID
    image

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Sep 13, 2023

Passing run #4139 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3c35bbb into 11e839a...
Project: fides Commit: 6571f5cb61 ℹ️
Status: Passed Duration: 01:00 💡
Started: Sep 14, 2023 4:17 AM Ended: Sep 14, 2023 4:18 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! :shipit:

import {
DirtyFormConfirmationModal,
useIsAnyFormDirty,
} from "~/features/common/hooks/useIsAnyFormDirty";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Kelsey-Ethyca Kelsey-Ethyca merged commit 52a06a4 into main Sep 14, 2023
10 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the diff-modal-patch branch September 14, 2023 04:23
Kelsey-Ethyca added a commit that referenced this pull request Sep 14, 2023
Co-authored-by: Kelsey Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants