Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice toggle error toast #4095

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 14, 2023

Closes #4092

Description Of Changes

image

New error toast for if an error comes up while enabling/disabling a privacy notice. Since this is a shared component, privacy experiences and custom fields also get the same upgrade!

Code Changes

  • Inspect the result of the PATCH for errors, and render a toast if needed
  • Cypress test

Steps to Confirm

  • See steps in the issue

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #4162 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e23a175 into 02f109c...
Project: fides Commit: e0be5d8bd0 ℹ️
Status: Passed Duration: 01:27 💡
Started: Sep 14, 2023 6:04 PM Ended: Sep 14, 2023 6:05 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 14, 2023 16:30
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪃

CHANGELOG.md Outdated Show resolved Hide resolved
@allisonking allisonking merged commit 60394c1 into main Sep 14, 2023
10 checks passed
@allisonking allisonking deleted the aking/4092/notice-toggle-error-toast branch September 14, 2023 18:07
allisonking added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error shown in UI when enabling/disabling a privacy notice errors
3 participants