-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows CDN to cache empty experiences responses from fides.js API #4113
Conversation
Passing run #4223 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
4954103
to
3525c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah this is a tricky problem!!
can we try to make the types stricter? I think once we make it stricter, some other pieces will fall into place, and we might not need some of the helper methods 🤞 of course, TS can often be tricky, so maybe my theory won't pan out, but I think it's worth trying, and will be less likely to bite us in the future
c0b5381
to
aebde26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
) Co-authored-by: Allison King <[email protected]>
) Co-authored-by: Allison King <[email protected]>
Closes #4108
Description Of Changes
Updates experience API to return empty obj instead of undefined when no experience was found for a specific location. This allows cache to work properly under this scenario, meaning that requests to the server will decrease overall.
Code Changes
Steps to Confirm
Got experience response from Fides API, returning:
and see that{}
is returned instead of being undefined or null.Pre-Merge Checklist
CHANGELOG.md