Add fields to System PUT payload #4116
Conversation
…_progress to system api so DB is not overwritten with null values
Passing run #4218 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
| @@ -102,6 +102,11 @@ export const transformFormValuesToSystem = (formValues: FormValues): System => { | |||
| vendor_id: formValues.vendor_id, | |||
| ingress: formValues.ingress, | |||
| egress: formValues.egress, | |||
| meta: formValues.meta, | |||
| fidesctl_meta: formValues.fidesctl_meta, | |||
| registry_id: formValues.registry_id, | |||
There was a problem hiding this comment.
We have a weird thing with the registry_id looks like. I have no idea what this field is for, but validation expects an integer, but sqlalchemy expects a string. If FE is sending an integer here, that will fail at sqlalchemy db level. Maybe we leave out this one.
Failed to update resource (sqlalchemy.dialects.postgresql.asyncpg.Error) <class 'asyncpg.exceptions.DataError'>: invalid input for query argument $6: 1 (expected str, got int)
There was a problem hiding this comment.
registries are an extremely old and never-used feature...honestly should just remove it
It was conceived as a way to help organizations organize their fides resources into sub-units. Specifically you could assign systems to a registry to logically "group" them. This use-case has never materialized
There was a problem hiding this comment.
ah okay thanks for the background Thomas!
…b.com/ethyca/fides into kt-4033-populate-system-fields-for-DB
Code Changes
Steps to Confirm
"meta": { "kubernetes_namespace": "plc" }Pre-Merge Checklist
CHANGELOG.md