-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning GVL.JSON through Experiences API #4143
Conversation
- Have copied file into src/fides/data - assume FE is going to remove the file of the same name on that end.
Passing run #4339 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4143 +/- ##
===========================================
+ Coverage 64.94% 87.50% +22.56%
===========================================
Files 326 326
Lines 20324 20342 +18
Branches 2640 2643 +3
===========================================
+ Hits 13199 17800 +4601
+ Misses 6657 2082 -4575
+ Partials 468 460 -8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me! I'll work on #3941 today to get the FE to start consuming this and make sure all is good, then we can remove its version of gvl.json. I can work off of this branch, and then we can merge that one with this PR? so that we don't pollute main
with two GVL.json files 😄 but if that's not a concern then merging this one first would be fine too!
That sounds perfect @allisonking! |
Oh actually, while you're here, let's use the latest GVL: https://vendor-list.consensu.org/v3/vendor-list.json (updated 9/21) |
Frontend piece: #4159 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preemptively approving, once the FE piece gets merged in here, assuming CI passes, let's get this merged into main
.
just a general note/disclaimer that the hardcoded gvl.json
is a workaround until this API is moved over to fidesplus
and we leverage the dynamically fetched vendor list that's maintained there!
Thank you for your updates Allison! |
Closes https://github.com/ethyca/fidesplus/issues/1109
Description Of Changes
Returning gvl.json under GET /privacy-experience for TCF experiences with an
include_gvl=True
query paramHave copied file into src/fides/data - assume FE is going to remove the file of the same name on that end.
Code Changes
include_gvl
query param to GET Privacy ExperienceSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md