Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retention #4199

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Fix retention #4199

merged 3 commits into from
Oct 2, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 29, 2023 •
edited by eastandwestwind
Loading

Closes N/A

Description Of Changes

Uses the stdRetention number if there is no specific number of retention days for a given purpose.

Code Changes

  • Fill in stdRetention as needed

Steps to Confirm

  • Set up your TCF environment and add a vendor from the dictionary
  • Instead of N/As, you should now see the default stdRetention value as expected

image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 29, 2023 •
edited
Loading

Passing run #4436 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge f35456b into 76af3fa...
Project: fides Commit: 400e86d0ad ℹ️
Status: Passed Duration: 00:50 💡
Started: Oct 2, 2023 2:35 PM Ended: Oct 2, 2023 2:36 PM

Review all test suite changes for PR #4199 ↗︎

@allisonking allisonking marked this pull request as ready for review October 2, 2023 14:28
eastandwestwind
eastandwestwind approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@allisonking allisonking merged commit 7b470e3 into main Oct 2, 2023
11 checks passed
@allisonking allisonking deleted the aking/fix-retention-days branch October 2, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @eastandwestwind