Use Fides String instead of TC String language #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T Experience and PATCH Privacy Preferences endpoints to pave the way for both a TC and AC string being combined in one string.
Passing run #4603 ↗︎
Details:
Review all test suite changes for PR #4267 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 331 331
Lines 20870 20870
Branches 2708 2708
=======================================
Hits 18309 18309
Misses 2094 2094
Partials 467 467
☔ View full report in Codecov by Sentry. |
allisonking
approved these changes
Oct 13, 2023
| "available options" | ||
| ) | ||
| reject_all_tc_mobile_data: Optional[TCMobileData] = None | ||
| reject_all_fides_mobile_data: Optional[TCMobileData] = None |
There was a problem hiding this comment.
we'll need to update the TS types, but we can do that separately since nothing in the FE is using these yet 👍 I'll go and update all types in one sweep after this release
There was a problem hiding this comment.
OK perfect thank you Allison. I'll merge this one to go out ahead in this release.
pattisdr
added a commit
that referenced
this pull request
Oct 13, 2023
eastandwestwind
pushed a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/1163
Description Of Changes
Use more generic "fides_string" instead of "tc_string" language in GET Experience and PATCH Privacy Preferences endpoints to pave the way for both a TC and AC string being combined in one string.
Code Changes
Steps to Confirm
See internal dev docs for expected behavior
Pre-Merge Checklist
CHANGELOG.md