Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing hidden sections to use display none #4299

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Forcing hidden sections to use display none #4299

merged 2 commits into from
Oct 19, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Oct 18, 2023 •
edited
Loading

Description Of Changes

Sections with a hidden attribute need to stay hidden regardless of externally defined CSS rules

<section hidden...>

Code Changes

  • Updating fides.css to specify section[hidden] as display: none

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana requested a review from NevilleS October 18, 2023 22:23
@cypress
Copy link

cypress bot commented Oct 18, 2023 •
edited
Loading

Passing run #4686 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a135a83 into a9b5950...
Project: fides Commit: 352d3b4c96 ℹ️
Status: Passed Duration: 00:53 💡
Started: Oct 18, 2023 10:36 PM Ended: Oct 18, 2023 10:37 PM

Review all test suite changes for PR #4299 ↗︎

NevilleS
NevilleS approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks 👍

@galvana galvana merged commit 7b15ac1 into main Oct 19, 2023
11 checks passed
@galvana galvana deleted the fix-modal-sections-not-hidding branch October 19, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @NevilleS