PROD-1266 Removes overflow styling for embedded modal in Fides.js #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastandwestwind
force-pushed
the
PROD-1266
branch
from
5eb30d7
to
12106a6
Compare
Passing run #4850 ↗︎
Details:
Review all test suite changes for PR #4345 ↗︎ |
||||||||||||||||||||
NevilleS
approved these changes
Oct 26, 2023
| @@ -6,21 +6,26 @@ | |||
| import A11yDialogLib from "a11y-dialog"; | |||
| import { useCallback, useEffect, useState } from "preact/hooks"; | |||
|
|
|||
| const useA11yDialogInstance = () => { | |||
| const useA11yDialogInstance = (addOverlowStyling: Boolean) => { | |||
There was a problem hiding this comment.
I'm OK with this as a test fix; but it's really narrow and still leaves behind an a11y-dialog instance when we aren't actually showing a dialog.
Can you create a new PROD bug and assign to current sprint like "Fix a11y issues with embedded modal" to follow up further here? Because right now it has some issues:
- appears to automatically grab focus on open, which can force a jarring page scroll
- labeled as
role="alertdialog"andaria-modal="true"which will likely confuse a screen reader / etc. - basically just feels wrong 👍
There was a problem hiding this comment.
NevilleS
pushed a commit
that referenced
this pull request
Oct 29, 2023
NevilleS
added a commit
that referenced
this pull request
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1266
Description Of Changes
Removes overflow styling for embedded modal in Fides.js
Code Changes
Steps to Confirm
style="overflow-y: hidden;"is not added to<html>tagPre-Merge Checklist
CHANGELOG.md