Restrict TCF Privacy Experience Config if TCF Disabled #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up in GET /privacy-experience-config if TCF is not enabled.
pattisdr
changed the title
Passing run #4873 ↗︎
Details:
Review all test suite changes for PR #4348 ↗︎ |
||||||||||||||||||||
pattisdr
commented
Oct 26, 2023
| @@ -1,6 +1,7 @@ | |||
| export const COMPONENT_MAP = new Map([ | |||
| ["overlay", "Overlay"], | |||
| ["privacy_center", "Privacy center"], | |||
| ["tcf_overlay", "TCF overlay"], | |||
There was a problem hiding this comment.
I didn't break the cypress tests with this did I? I think I see those same failures on main?
There was a problem hiding this comment.
yup no worries—we know about the failures on main and are working on it separately! thanks for updating this 👍
pattisdr
commented
Oct 26, 2023
Comment on lines
+90
to
+94
| if not CONFIG.consent.tcf_enabled: | ||
| privacy_experience_config_query = privacy_experience_config_query.filter( | ||
| PrivacyExperienceConfig.component != ComponentType.tcf_overlay | ||
| ) | ||
|
|
There was a problem hiding this comment.
This is the primary change of this PR!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4348 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 335 335
Lines 21157 21160 +3
Branches 2752 2753 +1
=======================================
+ Hits 18560 18563 +3
Misses 2127 2127
Partials 470 470
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1273
Description Of Changes
We have an endpoint that retrieves the Privacy Experience Config resources, which contain the language or the copy used for each experience type. This is the endpoint that is queried on the "Privacy Experience" page. TCF copy returns, regardless of whether TCF is enabled.
Code Changes
tcf_overlaycomponent type in the Privacy Experience Admin UISteps to Confirm
nox -s dev -- shellhttp://localhost:8080/api/v1/experience-config?show_disabled=true&page=1&size=50tcf_overlayisn't there.nox -s dev -- shellagainAlso adds this casing change:
Pre-Merge Checklist
CHANGELOG.md