implement enabled actions support in a more extensible manner #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
adamsachs
changed the title
adamsachs
commented
Nov 4, 2023
| @@ -17,3 +18,18 @@ class SaasConnectionTemplateValues(BaseModel): | |||
|
|
|||
| class Config: | |||
| extra = Extra.ignore | |||
|
|
|||
| def generate_config_data_from_template( | |||
There was a problem hiding this comment.
i think pydantic objects must be proper instances that can be accessed this way, right? tbh i'm actually not 100% sure and pydantic can feel a bit 🪄 sometimes, so this is the main assumption that needs to be validated!
There was a problem hiding this comment.
from my initial testing, i think this does work as expected 👍
Passing run #5021 ↗︎
Details:
Review all test suite changes for PR #4386 ↗︎ |
|||||||||||||||
galvana
merged commit cf45f14
into
PROD-1249-configure-enabled-actions
31 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes n/a
Description Of Changes
A tweak that attempts to address my concerns in #4374 (review)
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md