Gracefully handle Foreign Key Constraint Errors #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #5345 ↗︎
Details:
Review all test suite changes for PR #4406 ↗︎ |
||||||||||||||||||||
ThomasLaPiana
commented
Nov 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4406 +/- ##
==========================================
+ Coverage 87.08% 87.10% +0.01%
==========================================
Files 329 329
Lines 20309 20386 +77
Branches 2610 2627 +17
==========================================
+ Hits 17687 17758 +71
- Misses 2160 2163 +3
- Partials 462 465 +3 ☔ View full report in Codecov by Sentry. |
adamsachs
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
nice @ThomasLaPiana , this makes sense and looks good to me! i was able to verify with some basic local testing with fides_env (see screenshot below).
only thing is whether we'd want a bit of automated test coverage, if that's not too hard to get in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1108?focusedCommentId=37809
Description Of Changes
When someone deletes a
dataset, it throws an error due to foreign key constraints if there is a referencedconnectionThe solution is to update our
deletelogic to more intelligently catch and surface errors relate to foreign key constraints instead of blanket labeling everything as the same error.Code Changes
Steps to Confirm
Steps to Reproduceno longer work in the Jira ticketPre-Merge Checklist
CHANGELOG.mdThe new error message: